[SOLVED ]abcde ripper not creating id3 tags

[madeye]

I've run into a little trouble with abcde. When it is run, it rips and encodes the files correctly, but it cannot create the id3 tags.
First I had the error message

Code: Select all

--set-encoding=UTF16(something) not a known switch

That was taken care of by commenting out the line

Code: Select all

${ENCODING:+--set-encoding="$ENCODING"} \

in the bash script.

Now however I am being told the there is no write access to the files when I run the program?

Code: Select all

/usr/bin/abcde: line 834: /home/mp3/tmp/abcde.b60b200e/track03.mp3: Permission denied

Am I missing something? AFAICT all dependencies are installed correctly.

[wintpe]

usually a permission denied means you dont have write access.

outside of abcde try

Code: Select all

touch /home/mp3/tmp/xxx.txt


as the same user you are running abcde as

by default only access to your /home/username/* is writeable by username.

you may need to open up permission on /home/mp3/

as root run

Code: Select all

chown -R username   /home/mp3/


regards peter

[madeye]

I figured it out. But it did not have anything to do with the permissions.

When I wanted to disable the line in the abcde script, I only commented it out with a #. It seems this is not a good idea when the code is a block where every line is terminated with a backslash. (see the code below)

Code: Select all

# FIXME # track numbers in mp3 come with 1/10, so we cannot
# happily substitute them with $TRACKNUM
run_command tagtrack-$OUTPUT-$1 nice $ENCNICE $TAGGER $TAGGEROPTS \
   --comment=::"$COMMENTOUTPUT" -A "$DALBUM" \
   #${ENCODING:+--set-encoding="$ENCODING"} \
   -a "$TRACKARTIST" -t "$TRACKNAME" -Y "$CDYEAR" \
   -G "$GENREID" -n "${TRACKNUM:-$1}" \
   ${TRACKNUM:+-N "$TRACKS"} \
   ${TPE2:+--set-text-frame=TPE2:"$TPE2"} \
   "$ABCDETEMPDIR/track$1.$OUTPUT"
   ;;


The line needs to be removed completely. Then it works as expected.
That's what happens when you're not careful. (and don't understand the meaning of the \ )

[doktor5000]

Hint: next time run the script via bash -x to catch something like this - but still needs an eagle eye

[madeye]

Just a little heads up on this script.
It seems that there is a patch available to make it work correctly again. Although I didn't have any succes implementing it.

I ended up with taking the script from my old Arch linux install instead, copied it to /usr/local/bin and am using it now. It works perfectly.

Bug report upstream: (where also the patch is)
http://code.google.com/p/abcde/issues/detail?id=101