[SOLVED] "Mark forums read" button.....

This is the place to talk about our forums:
Questions about how to best use them, discussions about new features and things like that

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 25th, '11, 13:48

On the site we are still running 3.0.7pl1
At home in my test environment I have already updated to 3.0.9 (current version), will do the site update this week.

I'll look closer if I can find something I forgot here. I've been using this too long already, so I may have forgotten some change I made in the early stages of phpbb3 :)
If I can't find anything then I'll pass it over to you because then I am sure the cause is on your side. :)

Give me a couple of days, pls.
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 25th, '11, 14:23

No problem.

If we can find a way to quicken things there is no reason to miss the opportunity :)
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 25th, '11, 18:50

Found the diff! it could not work without declaring this. BTW: I do not think it is so ugly! :)

In 'search.php' (start line 42):
Code: Select all
$return_chars   = request_var('ch', ($topic_id) ? -1 : 300);
$search_forum   = request_var('fid', array(0));

// <---Start  "U_MARK_FORUMS"--->
$template->assign_vars(array(
        'U_MARK_FORUMS'         => ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'hash=' . generate_link_hash('global') . &amp;mark=forums') : '')
);
// <---End--->

// We put login boxes for the case if search_id is egosearch or unreadposts
// because a guest should be able to log in even if guests search is not permitted

// Egosearch is an author search


Ok, following the "Ease of maintenance first!" paradigm I understand that this is not an option for the Mageia forums. :)
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 25th, '11, 18:57

Well in fact it IS an option.

The low level source code management set up while not perfect should allow to add a patch and get rid of it later.

As this one is not too complex i think we could try to push it online till we move to 3.0.10 (when it's out) where we'll have to remember that it must be removed to avoid conflicts.

:)
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 25th, '11, 19:00

maat wrote:Well in fact it IS an option.

The low level source code management set up while not perfect should allow to add a patch and get rid of it later.

As this one is not too complex i think we could try to push it online till we move to 3.0.10 (when it's out) where we'll have to remember that it must be removed to avoid conflicts.
:)

I haven't looked at 3.0.10 yet - will there be a conflict with that? If so, hopefully there will be an option to replace it. From the users at mandrivauser.de (and my own experience) this is a very handy feature.
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 25th, '11, 19:26

Just something odd : the patch you gave is not correct on a PHP syntax point of view. If i push it online as is the search feature will be broken.

After second glance i think that there is a missing quote before the last "&amp"... but id'like to be sure. Perhaps there is more missing ?

Edit : answer to the last post i missed :

wobo wrote:
maat wrote:Well in fact it IS an option.

The low level source code management set up while not perfect should allow to add a patch and get rid of it later.

As this one is not too complex i think we could try to push it online till we move to 3.0.10 (when it's out) where we'll have to remember that it must be removed to avoid conflicts.
:)

I haven't looked at 3.0.10 yet - will there be a conflict with that? If so, hopefully there will be an option to replace it. From the users at mandrivauser.de (and my own experience) this is a very handy feature.


3.0.10 is supposed to solve this problem hence it will add a feature competing with the patch we are discussing...
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 26th, '11, 04:20

maat wrote:After second glance i think that there is a missing quote before the last "&amp"... but id'like to be sure.

Yes, it's obvious if you look a bit closer than I did when I c&p the strings into the forum. :( The quote opens before "&amp" and closes after "forums".
Can't edit the string in my forum post any more.

3.0.10 is supposed to solve this problem hence it will add a feature competing with the patch we are discussing...

Ah, ok, a solution without hack is always better.
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 26th, '11, 20:55

I see that you put the "Mark forums read" in the search result view - but it is not working there.
I guess the code in search.php is not updated yet as you requested in the sysadmin mailing list?

EDIT: I just see that the "mark forums read" link in search results points to the search results, not to "mark_forums".
The link in mandrivauser.de points to /forum/index.php?hash=2401ea4b&mark=forums
Last edited by wobo on Jul 26th, '11, 21:00, edited 1 time in total.
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 26th, '11, 20:59

wobo wrote:I see that you put the "Mark forums read" in the search result view - but it is not working there.
I guess the code in search.php is not updated yet as you requested in the sysadmin mailing list?


yup... the time for them to deal with urgent matters and it will be our turn
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 26th, '11, 21:01

wobo wrote:EDIT: I just see that the "mark forums read" link in search results points to the search results, not to "mark_forums".
The link in mandrivauser.de points to /forum/index.php?hash=2401ea4b&mark=forums
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 26th, '11, 21:07

wobo wrote:
wobo wrote:EDIT: I just see that the "mark forums read" link in search results points to the search results, not to "mark_forums".
The link in mandrivauser.de points to /forum/index.php?hash=2401ea4b&mark=forums


As the U_MARK_FORUMS field is not defined in search.php the value in the template is empty and so is the link url :
Code: Select all
<a href="">Mark forums read</a>


The browser translates this empty url by "remain on the same page" and shows on mouse over the same link as the page you're browsing.

Edit: once search.php is updated from git with the patch you'll see the correct url to mark all forums read :)
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 26th, '11, 21:39

Ah, thx for the clarification. So we are not far away from marking this topic as [solved] Image
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: "Mark forums read" button in other views than Board Inde

Postby maat » Jul 26th, '11, 22:18

I think you can test it now ;)
maat
 
Posts: 307
Joined: Feb 13th, '11, 00:23

Re: "Mark forums read" button in other views than Board Inde

Postby wobo » Jul 27th, '11, 02:46

Yes, works as expected. I think one of the Edit Masters can mark this as solved, finally.
Solved for German forum as well.

Next!
wobo
---
And a new day will dawn for those who stand long
And the forests will echo with laughter
(Stairway to Heaven, Led Zeppelin)
User avatar
wobo
 
Posts: 1649
Joined: Mar 22nd, '11, 17:13

Re: [SOLVED] "Mark forums read" button.....

Postby roadrunner » Jul 27th, '11, 09:58

Yep, I can confirm that it's solved here too :D

Thank you to everyone for their efforts on this, much appreciated, have a nice day.

.\\artin
- Mageia6 - 64-bit - Plasma 5.8.7 -
- AMD A6-6400K APU -
- 8Gb RAM - nVidia 8500GT GPU -
User avatar
roadrunner
 
Posts: 71
Joined: Jun 1st, '11, 16:00
Location: United Kingdom

Re: [SOLVED] "Mark forums read" button.....

Postby isadora » Jul 27th, '11, 10:13

Sorry, i had to shorten the original title from OP, because it didn't leave enough space for [SOLVED]-addition.
..........bird from paradise..........

Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.
—Antoine de Saint-Exupéry
User avatar
isadora
 
Posts: 2742
Joined: Mar 25th, '11, 16:03
Location: Netherlands

Previous

Return to Discussions about forums

Who is online

Users browsing this forum: No registered users and 1 guest

cron